Enable "SafariViewController.hide()" for Chrome Custom Tabs #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We did some testing on this and noted one minor change that was required to the modified code: case "hide": {
cordova.getActivity().startActivity(new Intent(cordova.getActivity(), cordova.getActivity().getClass()));
callbackContext.sendPluginResult(new PluginResult(PluginResult.Status.OK, true));
return true;
}Just added the |
alexgonch
added a commit
to alexgonch/cordova-plugin-safariviewcontroller
that referenced
this pull request
May 20, 2021
BendingBender
added a commit
to treefin/cordova-plugin-safariviewcontroller
that referenced
this pull request
Jul 16, 2021
BendingBender
added a commit
to treefin/cordova-plugin-safariviewcontroller
that referenced
this pull request
Jul 26, 2021
BendingBender
added a commit
to treefin/cordova-plugin-safariviewcontroller
that referenced
this pull request
Jul 30, 2021
|
@EddyVerbruggen can this be merged? |
|
+1 for a merge — just tested this PR, and it works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented fix as discussed in #105. Tested and is working fine in my use-case.
Works with and without
<preference name="AndroidLaunchMode" value="singleTask" />. Although without the preference,SafariViewController.hide()causes a new "layer" of the Cordova app to be instantiated. This means that after manually callingSafariViewController.hide()the app's user would lose their place within the app because it's essentially restarting from what I can tell. Because of this, I would recommend that<preference name="AndroidLaunchMode" value="singleTask" />is added.Not sure that this would resolve #105, but it does enable
SafariViewController.hide()to function on Android as it does iOS.